diff --git a/packages/contracts/package.json b/packages/contracts/package.json index b8ec218..c5fd75a 100644 --- a/packages/contracts/package.json +++ b/packages/contracts/package.json @@ -12,7 +12,6 @@ } }, "scripts": { - "build": "tsc -p tsconfig.json", - "test": "vitest run" + "build": "tsc -p tsconfig.json" } } diff --git a/packages/contracts/src/universal-row.ts b/packages/contracts/src/universal-row.ts index bbcbe16..2e6307d 100644 --- a/packages/contracts/src/universal-row.ts +++ b/packages/contracts/src/universal-row.ts @@ -20,17 +20,22 @@ export interface UniversalRow { rawLocation: string } -const REQUIRED: (keyof UniversalRow)[] = [ +type RequiredKeys = { [K in keyof T]-?: {} extends Pick ? never : K }[keyof T] + +// 契约冻结:REQUIRED = 接口必填字段全集;接口新增必填字段而列表漏改 → 编译报错 +const REQUIRED = [ 'sourceType', 'sourceId', 'status', 'locale', 'taxonomyRefs', 'attachmentRefs', 'seo', 'knownFields', 'extras', 'rawLocation', -] +] as const + +type _RequiredKeysMatch = [RequiredKeys] extends [typeof REQUIRED[number]] ? true : never +const _requiredKeysComplete: _RequiredKeysMatch = true export function isUniversalRow(v: unknown): v is UniversalRow { if (typeof v !== 'object' || v === null) return false const row = v as Record return REQUIRED.every((k) => k in row) && Array.isArray(row.taxonomyRefs) && Array.isArray(row.attachmentRefs) - && row.seo !== null && typeof row.seo === 'object' - && row.knownFields !== null && typeof row.knownFields === 'object' - && row.extras !== null && typeof row.extras === 'object' + && ['sourceType','sourceId','status','locale','rawLocation'].every((k) => typeof row[k] === 'string') + && [row.seo, row.knownFields, row.extras].every((x) => typeof x === 'object' && x !== null && !Array.isArray(x)) } diff --git a/packages/contracts/test/universal-row.test.ts b/packages/contracts/test/universal-row.test.ts index 31bad0e..828391b 100644 --- a/packages/contracts/test/universal-row.test.ts +++ b/packages/contracts/test/universal-row.test.ts @@ -25,3 +25,33 @@ describe('UniversalRow 契约', () => { expect(isUniversalRow(bad)).toBe(false) }) }) + +const REQUIRED_KEYS = [ + 'sourceType', 'sourceId', 'status', 'locale', + 'taxonomyRefs', 'attachmentRefs', 'seo', 'knownFields', 'extras', 'rawLocation', +] as const + +describe('UniversalRow 守卫拒绝路径', () => { + it.each(REQUIRED_KEYS)('缺必填字段 %s 拒绝', (key) => { + const clone: Record = { ...valid } + delete clone[key] + expect(isUniversalRow(clone)).toBe(false) + }) + + it('非对象输入拒绝(null / number)', () => { + expect(isUniversalRow(null)).toBe(false) + expect(isUniversalRow(42)).toBe(false) + }) + + it('taxonomyRefs 非数组拒绝', () => { + expect(isUniversalRow({ ...valid, taxonomyRefs: 'oops' })).toBe(false) + }) + + it('必填字符串字段非字符串拒绝(sourceId 数字)', () => { + expect(isUniversalRow({ ...valid, sourceId: 101 })).toBe(false) + }) + + it('seo 为数组拒绝(数组伪装对象)', () => { + expect(isUniversalRow({ ...valid, seo: [] })).toBe(false) + }) +})