fix: sites 标量 domains 防御/_to_bool/403 锁定/注释
- _norm_domains 入口类型守卫:domains 传数字曾 500、字符串曾逐字符 迭代成单字符域名静默落库,统一走 invalid_domains 400 - bool() 强转换 _to_bool:"false" 字符串曾是 True,对 allow_no_origin 这类放宽开关方向不利,改按字面解析(其余未知值仍 False) - 补 member DELETE 不存在 pk → 403(先于 404)锁定测试 - SiteDetailView 注释删去 GET 字样(无 detail GET,前端走列表+Dialog) Co-Authored-By: Claude Code <noreply@anthropic.com>
This commit is contained in:
@@ -8,8 +8,10 @@ from tracker.models import Site
|
||||
|
||||
def _norm_domains(raw) -> list[str]:
|
||||
"""域名归一:去协议/端口/路径、转小写、去空去重。"""
|
||||
if isinstance(raw, str) or not isinstance(raw, (list, tuple)):
|
||||
return [] # 标量/字符串(会逐字符迭代成单字符域名)→ 走 invalid_domains 400
|
||||
out = []
|
||||
for d in raw or []:
|
||||
for d in raw:
|
||||
d = str(d).strip().lower()
|
||||
for pre in ("https://", "http://"):
|
||||
if d.startswith(pre):
|
||||
@@ -20,6 +22,16 @@ def _norm_domains(raw) -> list[str]:
|
||||
return out
|
||||
|
||||
|
||||
def _to_bool(v) -> bool:
|
||||
"""宽松布尔解析:bool 直通,"true"/"false" 字符串按字面(bool("false") 是 True,
|
||||
对 allow_no_origin 这类放宽开关方向不利),其余(数字/未知串/None)一律 False。"""
|
||||
if isinstance(v, bool):
|
||||
return v
|
||||
if isinstance(v, str) and v.lower() in ("true", "false"):
|
||||
return v.lower() == "true"
|
||||
return False
|
||||
|
||||
|
||||
def _serialize(site: Site) -> dict:
|
||||
return {"id": site.pk, "name": site.name, "site_id": site.site_id,
|
||||
"domains": site.domains, "allow_no_origin": site.allow_no_origin,
|
||||
@@ -39,13 +51,13 @@ class SiteListView(EnvelopeMixin, APIView):
|
||||
if not domains:
|
||||
return Response({"code": 400, "data": None, "message": "invalid_domains"}, status=400)
|
||||
site = Site.objects.create(name=name.strip()[:100], domains=domains,
|
||||
allow_no_origin=bool(data.get("allow_no_origin")))
|
||||
allow_no_origin=_to_bool(data.get("allow_no_origin")))
|
||||
return ok(_serialize(site), "created")
|
||||
|
||||
|
||||
class SiteDetailView(EnvelopeMixin, APIView):
|
||||
def get_permissions(self):
|
||||
# DELETE(软删)仅 admin;GET/PATCH 登录成员即可(settings 默认 IsAuthenticated)。
|
||||
# DELETE(软删)仅 admin;PATCH 登录成员即可(settings 默认 IsAuthenticated;无 detail GET,前端走列表)。
|
||||
# 在 initial() 阶段判权限:403 先于 404,且不泄露站点存在性。
|
||||
if self.request.method == "DELETE":
|
||||
return [IsAdminUser()]
|
||||
@@ -68,9 +80,9 @@ class SiteDetailView(EnvelopeMixin, APIView):
|
||||
return Response({"code": 400, "data": None, "message": "invalid_domains"}, status=400)
|
||||
site.domains = domains
|
||||
if "allow_no_origin" in data:
|
||||
site.allow_no_origin = bool(data["allow_no_origin"])
|
||||
site.allow_no_origin = _to_bool(data["allow_no_origin"])
|
||||
if "is_active" in data:
|
||||
site.is_active = bool(data["is_active"])
|
||||
site.is_active = _to_bool(data["is_active"])
|
||||
site.save()
|
||||
return ok(_serialize(site))
|
||||
|
||||
|
||||
Reference in New Issue
Block a user